ottoka commented on PR #1111: URL: https://github.com/apache/james-project/pull/1111#issuecomment-1211899157
Making InMemoryMessageMapper honor the fetch type seems to be a game of whack-a-mole. Issues crop up in parts of James I have never touched before, and I don't know how to handle them. It has reached a point where it distracts me too much from the original purpose of the PR, and the effort of making it work outweigh its usefulness to me. > Do we care about memory honoring the fetch type stuff? Ok, it makes it closer to real implementations (cassandra / JPA) meaning catching some issues earlier in the development cycle, but integration tests (here MPT IMAP tests?) still get us covered. While making memory fetch type aware the way Cassandra implem is would be a contribution I would support, I do not know if I would consider it 'essential' I will follow your reasoning here and will regrettably remove the InMemoryMessageMapper commit from this PR. If you are interested in this topic, I can keep it in a different branch in my personal repo, or create a separate PR here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
