chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1173467634
########## server/apps/memory-app/README.md: ########## @@ -32,6 +32,14 @@ keytool -genkey -alias james -keyalg RSA -keystore keystore docker run -v $PWD/keystore:/root/conf/keystore docker run apache/james:cassandra-latest ``` +In the case of quick start James without manually creating a keystore (e.g. for development), just input the command argument `start-dev` when running, +James will auto-generate keystore file with the default setting: + +``` +docker run apache/james:memory-latest start-dev Review Comment: ```suggestion docker run apache/james:memory-latest --generate-keystore ``` Is more idiomatic from command line, and likely more self explanatory. ########## server/apps/memory-app/README.md: ########## @@ -32,6 +32,14 @@ keytool -genkey -alias james -keyalg RSA -keystore keystore docker run -v $PWD/keystore:/root/conf/keystore docker run apache/james:cassandra-latest ``` +In the case of quick start James without manually creating a keystore (e.g. for development), just input the command argument `start-dev` when running, +James will auto-generate keystore file with the default setting: + +``` +docker run apache/james:memory-latest start-dev Review Comment: We should document first how to auto-generate the keystore, then explain how to set up your own... ########## server/apps/memory-app/README.md: ########## @@ -32,6 +32,14 @@ keytool -genkey -alias james -keyalg RSA -keystore keystore docker run -v $PWD/keystore:/root/conf/keystore docker run apache/james:cassandra-latest ``` +In the case of quick start James without manually creating a keystore (e.g. for development), just input the command argument `start-dev` when running, +James will auto-generate keystore file with the default setting: + +``` +docker run apache/james:memory-latest start-dev Review Comment: Please document `--generate-keystore` in all other applications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
