chibenwa commented on code in PR #1561:
URL: https://github.com/apache/james-project/pull/1561#discussion_r1198499473
##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailSubmissionSetMethodFutureReleaseContract.scala:
##########
@@ -206,27 +215,35 @@ trait EmailSubmissionSetMethodFutureReleaseContract {
val requestBob =
s"""{
- | "using": ["urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail", "urn:ietf:params:jmap:submission"],
- | "methodCalls": [
- | ["EmailSubmission/set", {
- | "accountId": "$ACCOUNT_ID",
- | "create": {
- | "k1490": {
- | "emailId": "${messageId.serialize}",
- | "envelope": {
- | "mailFrom": {
- | "email": "${BOB.asString}",
- | "parameters": {
- | "holdFor": 7600
- | }
- | },
- | "rcptTo": [{"email": "${ANDRE.asString}"}]
- | }
- | }
- | }
- | }, "c1"]]
+ | "using": ["urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail", "urn:ietf:params:jmap:submission"],
+ | "methodCalls": [
+ | ["EmailSubmission/set", {
+ | "accountId": "$ACCOUNT_ID",
+ | "create": {
+ | "k1490": {
+ | "emailId":
"${messageId.serialize}",
+ | "envelope": {
+ | "mailFrom": {
+ | "email":
"${BOB.asString}",
+ | "parameters": {
+ | "holdFor":
"76000"
+ | }
+ | },
+ | "rcptTo": [{
+ | "email":
"${ANDRE.asString}"
+ | }]
+ | }
+ | }
+ | }
+ | }, "c1"]
+ | ]
|}""".stripMargin
+ assertThatJson(requestBob)
+
.inPath("methodCalls[0][1].create.k1490.envelope.mailFrom.parameters.holdFor")
+ .asNumber()
+ .isLessThanOrEqualTo(new java.math.BigDecimal(maximumDelays.toSeconds))
+
Review Comment:
THis assertions is not exercising James logic and should be getten rid of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
