hungphan227 commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1264808350
##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/filtering/Rule.java:
##########
@@ -72,6 +72,60 @@ public String toString() {
}
}
+ public static class ConditionGroup {
+
+ private final ConditionCombiner conditionCombiner;
+ private final List<Condition> conditions;
+
+ public static ConditionGroup of(ConditionCombiner conditionCombiner,
List<Condition> conditions) {
+ return new ConditionGroup(conditionCombiner, conditions);
+ }
+
+ public static ConditionGroup of(ConditionCombiner conditionCombiner,
Condition... conditions) {
+ return new ConditionGroup(conditionCombiner,
ImmutableList.copyOf(conditions));
+ }
+
+ public static ConditionGroup of(Condition condition) {
+ return ConditionGroup.of(ConditionCombiner.AND, condition);
+ }
Review Comment:
static methods goes first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
