quantranhong1999 commented on code in PR #1663:
URL: https://github.com/apache/james-project/pull/1663#discussion_r1280353796
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/http/BasicAuthenticationStrategy.scala:
##########
@@ -129,7 +128,9 @@ class BasicAuthenticationStrategy @Inject()(val
usersRepository: UsersRepository
private def publishNext[T]: (Option[T],
reactor.core.publisher.SynchronousSink[T]) => Unit =
(maybeT, sink) => maybeT.foreach(t => sink.next(t))
- private def getAuthenticatedUsername(userCredential: UserCredential):
SMono[Option[Username]] =
- SMono.fromCallable(() => usersRepository.test(userCredential.username,
userCredential.password).toScala)
+ private def getAuthenticatedUsername(userCredential: UserCredential):
SMono[Username] =
+ SMono.fromCallable(() => usersRepository.test(userCredential.username,
userCredential.password)
+ .toScala
Review Comment:
```suggestion
```
No need anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
