Arsnael commented on code in PR #1666: URL: https://github.com/apache/james-project/pull/1666#discussion_r1285336275
########## core/src/main/java/org/apache/james/core/quota/QuotaComponentFactory.java: ########## @@ -0,0 +1,42 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.core.quota; + +import java.util.Set; + +import com.google.inject.Inject; + +public class QuotaComponentFactory { Review Comment: @chibenwa : I think @hungphan227 is concerned at the end that with this simple way, we might not be able to tell the user if we have quotas for the component or not when calling the webadmin api generic route. Maybe you don't care if we return an empty list in that case? Or maybe you don't want generic routes in the first place, and want to keep routes separated like it is the case now? (I think would be easier to have a generic route with the quota component in it though, as groomed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
