Arsnael commented on code in PR #1675:
URL: https://github.com/apache/james-project/pull/1675#discussion_r1293067254
##########
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/S3MinioTest.java:
##########
@@ -120,4 +121,10 @@ void saveShouldWorkForAllPayloadsWithHash() {
.block();
}
+ @Disabled("Minio changed and returns a generic S3Exception instead of a
NoSuchBucketException in its latest release." +
+ "Consequence is trying to delete a blob on a non existing bucket on
MinIO will throw an error, instead of being silenced.")
+ @Override
+ public void deleteShouldNotThrowWhenBucketDoesNotExist() {
+
+ }
Review Comment:
Oh well caught, the issue is actually the underscores and not something
else... Alright!
I think just modifying the base test is enough then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
