quantranhong1999 commented on code in PR #1671:
URL: https://github.com/apache/james-project/pull/1671#discussion_r1296645690
##########
server/mailet/rate-limiter-redis/src/main/scala/org/apache/james/rate/limiter/redis/RedisHealthCheck.scala:
##########
@@ -47,16 +49,18 @@ class RedisHealthCheck @Inject()(redisConfiguration:
RedisRateLimiterConfigurati
if (redisConfiguration.isCluster) {
val redisUris = redisConfiguration.redisURI.value.asJava
redisUris.forEach(redisUri => redisUri.setTimeout(healthcheckTimeout))
+ val redisClusterClient = RedisClusterClient.create(redisUris)
- SMono.fromPublisher(Mono.using(() =>
RedisClusterClient.create(redisUris),
- (redisClusterClient: RedisClusterClient) => Mono.fromCallable(() =>
redisClusterClient.connect()),
- (redisClusterClient: RedisClusterClient) =>
redisClusterClient.close()))
+
SMono.fromFuture(redisClusterClient.connectAsync(StringCodec.UTF8).asScala)
+ .doOnNext(redisConnection => redisConnection.closeAsync())
+ .doOnTerminate(() => redisClusterClient.close())
Review Comment:
Which ones do you mean?
`redisClusterClient.connectAsync `+ `redisConnection.closeAsync` -> non
blocking
`redisClusterClient.close()` -> release Java objects, should be fast enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
