Arsnael commented on code in PR #1699:
URL: https://github.com/apache/james-project/pull/1699#discussion_r1304041167
##########
server/data/data-jmap/src/test/java/org/apache/james/jmap/api/upload/UploadUsageRepositoryContract.scala:
##########
@@ -0,0 +1,48 @@
+package org.apache.james.jmap.api.upload
+
+import org.apache.james.core.Username
+import org.apache.james.core.quota.QuotaSizeUsage
+import org.apache.james.jmap.api.upload.UploadUsageRepositoryContract.USER_NAME
+import org.assertj.core.api.Assertions
+import org.junit.jupiter.api.Test
+import reactor.core.scala.publisher.SMono
+
+object UploadUsageRepositoryContract {
+ val USER_NAME = Username.of("[email protected]")
+}
+
+trait UploadUsageRepositoryContract {
+ def uploadUsageRepository: UploadUsageRepository
+
+ @Test
+ def increaseSpaceShouldIncreaseSuccessfully(): Unit = {
+
Assertions.assertThat(SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block().asLong()).isEqualTo(0);
+ SMono.fromPublisher(uploadUsageRepository.increaseSpace(USER_NAME,
QuotaSizeUsage.size(100))).block();
+ val expected =
SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block();
+ Assertions.assertThat(expected.asLong()).isEqualTo(100);
+ }
+
+ @Test
+ def decreaseSpaceShouldDecreaseSuccessfully(): Unit = {
+ SMono.fromPublisher(uploadUsageRepository.increaseSpace(USER_NAME,
QuotaSizeUsage.size(200))).block();
+
Assertions.assertThat(SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block().asLong()).isEqualTo(200);
Review Comment:
Assert unecessary. You have a test to prove that increase works as expected
already
##########
server/data/data-jmap/src/test/java/org/apache/james/jmap/api/upload/UploadUsageRepositoryContract.scala:
##########
@@ -0,0 +1,48 @@
+package org.apache.james.jmap.api.upload
+
+import org.apache.james.core.Username
+import org.apache.james.core.quota.QuotaSizeUsage
+import org.apache.james.jmap.api.upload.UploadUsageRepositoryContract.USER_NAME
+import org.assertj.core.api.Assertions
+import org.junit.jupiter.api.Test
+import reactor.core.scala.publisher.SMono
+
+object UploadUsageRepositoryContract {
+ val USER_NAME = Username.of("[email protected]")
+}
+
+trait UploadUsageRepositoryContract {
+ def uploadUsageRepository: UploadUsageRepository
+
+ @Test
+ def increaseSpaceShouldIncreaseSuccessfully(): Unit = {
+
Assertions.assertThat(SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block().asLong()).isEqualTo(0);
+ SMono.fromPublisher(uploadUsageRepository.increaseSpace(USER_NAME,
QuotaSizeUsage.size(100))).block();
+ val expected =
SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block();
+ Assertions.assertThat(expected.asLong()).isEqualTo(100);
+ }
+
+ @Test
+ def decreaseSpaceShouldDecreaseSuccessfully(): Unit = {
+ SMono.fromPublisher(uploadUsageRepository.increaseSpace(USER_NAME,
QuotaSizeUsage.size(200))).block();
+
Assertions.assertThat(SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block().asLong()).isEqualTo(200);
+ SMono.fromPublisher(uploadUsageRepository.decreaseSpace(USER_NAME,
QuotaSizeUsage.size(100))).block();
+ val expected =
SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block();
+ Assertions.assertThat(expected.asLong()).isEqualTo(100);
+ }
+
+ @Test
+ def resetSpaceShouldResetSuccessfully(): Unit = {
+ SMono.fromPublisher(uploadUsageRepository.increaseSpace(USER_NAME,
QuotaSizeUsage.size(200))).block();
+
Assertions.assertThat(SMono.fromPublisher(uploadUsageRepository.getSpaceUsage(USER_NAME)).block().asLong()).isEqualTo(200);
Review Comment:
Idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
