chibenwa commented on code in PR #1701:
URL: https://github.com/apache/james-project/pull/1701#discussion_r1306115545
##########
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/upload/UploadDAO.java:
##########
@@ -183,13 +172,18 @@ public UploadDAO(CqlSession session, BlobId.Factory
blobIdFactory, UploadConfigu
.whereColumn(USER).isEqualTo(bindMarker(USER))
.whereColumn(ID).isEqualTo(bindMarker(ID))
.build());
+
+ this.listByUploadDateLessThan = session.prepare(selectFrom(TABLE_NAME)
+ .all()
+ .allowFiltering()
+ .whereColumn(UPLOAD_DATE).isLessThan(bindMarker(UPLOAD_DATE))
Review Comment:
Do not push the where clause to the DB and prefer doing app side filtering
IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
