chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1372350706
##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/RecipientRewriteTableProcessor.java:
##########
@@ -223,37 +223,27 @@ static ForwardDecision removeRecipient(MailAddress
recipient) {
.collect(ImmutableList.toImmutableList()));
}
- static ForwardDecision sendACopy(MailetContext context, MailAddress
originalRecipient, List<MailAddress> forwards) {
+ static ForwardDecision sendACopy(MailetContext context,
+ MailAddress originalRecipient,
+ List<MailAddress> forwards,
+ LoopPrevention.RecordedRecipients
recordedRecipients,
+ Set<MailAddress> newRecipients) {
Review Comment:
Way too much arguments. With 4 different disguised list of mail address.
That's not reasonnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
