This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 7bce5b4edae5c18ff699fada809172cde7006f7e Author: Quan Tran <[email protected]> AuthorDate: Tue Jan 9 16:29:56 2024 +0700 JAMES-3897 CrowdsecHttpClientTest: some test statements were not taken into account --- .../test/java/org/apache/james/CrowdsecHttpClientTest.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/third-party/crowdsec/src/test/java/org/apache/james/CrowdsecHttpClientTest.java b/third-party/crowdsec/src/test/java/org/apache/james/CrowdsecHttpClientTest.java index 38cf40a08f..e6ee7c57f1 100644 --- a/third-party/crowdsec/src/test/java/org/apache/james/CrowdsecHttpClientTest.java +++ b/third-party/crowdsec/src/test/java/org/apache/james/CrowdsecHttpClientTest.java @@ -56,7 +56,8 @@ class CrowdsecHttpClientTest { SoftAssertions.assertSoftly(softly -> { softly.assertThat(decisions).hasSize(1); - softly.assertThat(decisions.get(0).getValue().equals("192.168.0.4") && decisions.get(0).getType().equals(BAN)); + softly.assertThat(decisions.get(0).getValue()).isEqualTo("192.168.0.4"); + softly.assertThat(decisions.get(0).getType()).isEqualTo(BAN); }); } @@ -70,7 +71,8 @@ class CrowdsecHttpClientTest { SoftAssertions.assertSoftly(softly -> { softly.assertThat(decisions).hasSize(1); - softly.assertThat(decisions.get(0).getValue().equals("192.168.0.0/16") && decisions.get(0).getType().equals(BAN)); + softly.assertThat(decisions.get(0).getValue()).isEqualTo("192.168.0.0/16"); + softly.assertThat(decisions.get(0).getType()).isEqualTo(BAN); }); } @@ -103,7 +105,7 @@ class CrowdsecHttpClientTest { CrowdsecHttpClient httpClient = new CrowdsecHttpClient(config); List<CrowdsecDecision> decisions = httpClient.getCrowdsecDecisions().block(); - assertThat(decisions).hasSize(0); + assertThat(decisions).isEmpty(); } @Test @@ -117,8 +119,10 @@ class CrowdsecHttpClientTest { SoftAssertions.assertSoftly(softly -> { softly.assertThat(decisions).hasSize(2); - softly.assertThat(decisions.get(0).getValue().equals("192.168.0.4") && decisions.get(0).getType().equals(BAN)); - softly.assertThat(decisions.get(1).getValue().equals("192.168.0.5") && decisions.get(1).getType().equals(BAN)); + softly.assertThat(decisions).extracting(CrowdsecDecision::getValue) + .containsExactlyInAnyOrder("192.168.0.4", "192.168.0.5"); + softly.assertThat(decisions).extracting(CrowdsecDecision::getType) + .containsOnly(BAN); }); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
