quantranhong1999 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1501987659
##########
server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresThreadGetTest.java:
##########
@@ -88,31 +60,11 @@ public class PostgresThreadGetTest extends PostgresBase
implements ThreadGetCont
.overrideWith(new TestJMAPServerModule()))
.build();
- @AfterEach
- void tearDown() throws IOException {
- client.close();
- }
-
@Override
public void awaitMessageCount(List<MailboxId> mailboxIds, SearchQuery
query, long messageCount) {
- awaitForOpenSearch(queryConverter.from(mailboxIds, query),
messageCount);
}
@Override
public void initOpenSearchClient() {
- client = MailboxIndexCreationUtil.prepareDefaultClient(
- openSearch.getDockerOpenSearch().clientProvider().get(),
- openSearch.getDockerOpenSearch().configuration());
- }
-
- private void awaitForOpenSearch(Query query, long totalHits) {
Review Comment:
Why remove this?
##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresAttachmentModule.java:
##########
@@ -35,20 +35,22 @@ public interface PostgresAttachmentModule {
interface PostgresAttachmentTable {
Table<Record> TABLE_NAME = DSL.table("attachment");
- Field<UUID> ID = DSL.field("id", SQLDataType.UUID.notNull());
+ Field<UUID> ID_AS_UUID = DSL.field("id_as_uuid",
SQLDataType.UUID.notNull());
+ Field<String> ID = DSL.field("id", SQLDataType.VARCHAR.notNull());
Review Comment:
So we need the "redundant" ID field just to pass IT? Any other way?
##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailQueryMethodContract.scala:
##########
@@ -7034,22 +7034,24 @@ trait EmailQueryMethodContract {
| "c1"]]
|}""".stripMargin
- val response = `given`
- .header(ACCEPT.toString, ACCEPT_RFC8621_VERSION_HEADER)
- .body(request)
- .when
- .post
- .`then`
- .statusCode(SC_OK)
- .contentType(JSON)
- .extract
- .body
- .asString
+ awaitAtMostTenSeconds.untilAsserted { () =>
+ val response = `given`
+ .header(ACCEPT.toString, ACCEPT_RFC8621_VERSION_HEADER)
+ .body(request)
+ .when
+ .post
+ .`then`
Review Comment:
indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
