quantranhong1999 commented on code in PR #2096:
URL: https://github.com/apache/james-project/pull/2096#discussion_r1519080682
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/JmapRfc8621Configuration.scala:
##########
@@ -46,6 +46,8 @@ object JmapConfigProperties {
val DISABLED_CAPABILITIES: String = "disabled.capabilities"
val JMAP_UPLOAD_QUOTA_LIMIT_PROPERTY: String = "upload.quota.limit"
val JMAP_EMAIL_GET_FULL_MAX_SIZE_PROPERTY: String = "email.get.full.max.size"
+ val JMAP_GET_MAX_SIZE_PROPERTY: String = "get.max.size"
+ val JMAP_SET_MAX_SIZE_PROPERTY: String = "set.max.size"
Review Comment:
documentation needed
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/JmapRfc8621Configuration.scala:
##########
@@ -56,6 +58,9 @@ object JmapRfc8621Configuration {
val MAX_SIZE_ATTACHMENTS_PER_MAIL_DEFAULT: MaxSizeAttachmentsPerEmail =
MaxSizeAttachmentsPerEmail.of(Size.of(20_000_000L, Size.Unit.B)).get
val JMAP_UPLOAD_QUOTA_LIMIT_DEFAULT: JmapUploadQuotaLimit =
JmapUploadQuotaLimit.of(Size.of(200L, Size.Unit.M)).get
val JMAP_EMAIL_GET_FULL_MAX_SIZE_DEFAULT: JmapEmailGetFullMaxSize =
JmapEmailGetFullMaxSize(UnsignedInt.liftOrThrow(5))
+ val JMAP_MAX_OBJECT_IN_GET: MaxObjectsInGet =
MaxObjectsInGet(UnsignedInt.liftOrThrow(500))
+ val JMAP_MAX_OBJECT_IN_EMAIL_GET_FULL: MaxObjectsInGet =
MaxObjectsInGet(UnsignedInt.liftOrThrow(5))
Review Comment:
```suggestion
```
Likely duplicated with `JMAP_EMAIL_GET_FULL_MAX_SIZE_DEFAULT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
