This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 1afab2124813fd5c11d337fe35e7c6ac7b8990c3 Author: Quan Tran <hqt...@linagora.com> AuthorDate: Wed Jan 31 13:23:03 2024 +0700 JAMES-3961 Cucumber tests should not fail the unstable test phase Actually, the Cucumber tests already run in the stable test phase. But with the `@Suite` annotation, the `maven-surefire-plugin` pulled the Cucumber tests into the unstable tests phase as well. Somehow during the unstable tests phase, the maven plugin could not detect any cucumber tests and failed the entire unstable test phase. --- .../src/test/java/org/apache/james/rrt/cassandra/RewriteTablesTest.java | 2 +- .../src/test/java/org/apache/james/rrt/jpa/RewriteTablesTest.java | 2 +- .../src/test/java/org/apache/james/rrt/memory/RewriteTablesTest.java | 2 +- .../james/jmap/memory/cucumber/MemoryDownloadEnpointCucumberTest.java | 2 +- .../james/jmap/memory/cucumber/MemoryDownloadGetCucumberTest.java | 2 +- .../james/jmap/memory/cucumber/MemoryDownloadPostCucumberTest.java | 2 +- .../apache/james/jmap/memory/cucumber/MemoryGetMessagesMethodTest.java | 2 +- .../jmap/memory/cucumber/MemoryIMAPKeywordsInconsistenciesTest.java | 2 +- .../jmap/memory/cucumber/MemoryIMAPSetMessagesCompatibilityTest.java | 2 +- .../jmap/memory/cucumber/MemorySetMailboxesMethodCucumberTest.java | 2 +- .../james/jmap/memory/cucumber/MemorySetMessagesMethodCucumberTest.java | 2 +- .../java/org/apache/james/jmap/memory/cucumber/MemorySharingTest.java | 2 +- .../org/apache/james/jmap/memory/cucumber/MemoryUploadCucumberTest.java | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/RewriteTablesTest.java b/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/RewriteTablesTest.java index 5223d5e5bf..a23f8bc61e 100644 --- a/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/RewriteTablesTest.java +++ b/server/data/data-cassandra/src/test/java/org/apache/james/rrt/cassandra/RewriteTablesTest.java @@ -25,7 +25,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @IncludeEngines("cucumber") @SelectClasspathResource("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.rrt.lib,org.apache.james.rrt.cassandra") diff --git a/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/RewriteTablesTest.java b/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/RewriteTablesTest.java index 35fcc586b4..a4269d3e40 100644 --- a/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/RewriteTablesTest.java +++ b/server/data/data-jpa/src/test/java/org/apache/james/rrt/jpa/RewriteTablesTest.java @@ -25,7 +25,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @IncludeEngines("cucumber") @SelectClasspathResource("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.rrt.lib,org.apache.james.rrt.jpa") diff --git a/server/data/data-memory/src/test/java/org/apache/james/rrt/memory/RewriteTablesTest.java b/server/data/data-memory/src/test/java/org/apache/james/rrt/memory/RewriteTablesTest.java index aba5dc7f3d..ad9e3a7e57 100644 --- a/server/data/data-memory/src/test/java/org/apache/james/rrt/memory/RewriteTablesTest.java +++ b/server/data/data-memory/src/test/java/org/apache/james/rrt/memory/RewriteTablesTest.java @@ -25,7 +25,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @IncludeEngines("cucumber") @SelectClasspathResource("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.rrt.lib,org.apache.james.rrt.memory") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadEnpointCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadEnpointCucumberTest.java index 59b62c5c50..f47529bc1c 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadEnpointCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadEnpointCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/DownloadEndpoint.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadGetCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadGetCucumberTest.java index 79629bb7b7..31274f7250 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadGetCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadGetCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/DownloadGet.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadPostCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadPostCucumberTest.java index 39deea1509..ad08536291 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadPostCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadPostCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/DownloadPost.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryGetMessagesMethodTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryGetMessagesMethodTest.java index e1028f2ea0..1bae175016 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryGetMessagesMethodTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryGetMessagesMethodTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/GetMessages.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPKeywordsInconsistenciesTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPKeywordsInconsistenciesTest.java index d60c854f55..2ac37e692c 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPKeywordsInconsistenciesTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPKeywordsInconsistenciesTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/ImapKeywordsConsistency.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPSetMessagesCompatibilityTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPSetMessagesCompatibilityTest.java index fdf20aae3b..2fa6b52d45 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPSetMessagesCompatibilityTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryIMAPSetMessagesCompatibilityTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/ImapSetMessagesMailboxesUpdatesCompatibility.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMailboxesMethodCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMailboxesMethodCucumberTest.java index 68a7e1f97d..2f1d929fdd 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMailboxesMethodCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMailboxesMethodCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/MailboxModification.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMessagesMethodCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMessagesMethodCucumberTest.java index e9a80e4cc2..d4c0824bd4 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMessagesMethodCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySetMessagesMethodCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/SetMessages.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySharingTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySharingTest.java index 1f4c40b4fe..cb8c6994b0 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySharingTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemorySharingTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/sharing") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") diff --git a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryUploadCucumberTest.java b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryUploadCucumberTest.java index 383a024721..3ec426b2a9 100644 --- a/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryUploadCucumberTest.java +++ b/server/protocols/jmap-draft-integration-testing/memory-jmap-draft-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryUploadCucumberTest.java @@ -27,7 +27,7 @@ import org.junit.platform.suite.api.IncludeEngines; import org.junit.platform.suite.api.SelectClasspathResource; import org.junit.platform.suite.api.Suite; -@Suite +@Suite(failIfNoTests = false) @SelectClasspathResource("cucumber/UploadEndpoint.feature") @IncludeEngines("cucumber") @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "org.apache.james.jmap.draft.methods.integration,org.apache.james.jmap.memory.cucumber") --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org