vttranlina commented on code in PR #2135:
URL: https://github.com/apache/james-project/pull/2135#discussion_r1531620981
##########
server/data/data-jmap-cassandra/src/test/java/org/apache/james/jmap/cassandra/upload/CassandraUploadRepositoryTest.java:
##########
@@ -76,16 +76,4 @@ public void deleteShouldReturnFalseWhenRowDoesNotExist() {
public UpdatableTickingClock clock() {
return clock;
}
-
- @Disabled("Delete method always return true (to avoid LWT)")
- @Override
- public void deleteShouldReturnTrueWhenRowExists() {
Review Comment:
no, please keep it
##########
server/data/data-jmap/src/test/java/org/apache/james/jmap/api/upload/UploadRepositoryContract.scala:
##########
@@ -217,18 +218,4 @@
assertThat(SMono.fromPublisher(testee.retrieve(uploadId2, USER)).block())
.isNotNull
}
-
- @Test
- def deleteShouldReturnTrueWhenRowExists(): Unit = {
Review Comment:
no, please keep it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
