vttranlina commented on code in PR #2193:
URL: https://github.com/apache/james-project/pull/2193#discussion_r1558977813
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/SessionSupplier.scala:
##########
@@ -80,11 +78,11 @@ class SessionSupplier(capabilityFactories:
Set[CapabilityFactory]) {
}
class JmapUrlEndpointResolver(val urlPrefixes: UrlPrefixes) {
- val apiUrl: URL = new URI(urlPrefixes.httpUrlPrefix.toString + "/jmap").toURL
+ val apiUrl: URL = URL(urlPrefixes.httpUrlPrefix.toString + "/jmap")
- val downloadUrl: URL = new URI(urlPrefixes.httpUrlPrefix.toString +
"/download/{accountId}/{blobId}?type={type}&name={name}").toURL
+ val downloadUrl: URL = URL(urlPrefixes.httpUrlPrefix.toString +
"/download/{accountId}/{blobId}?type={type}&name={name}")
Review Comment:
URI does not accept inputs containing {} characters. Upon examination, I
verified that: apiUrl, downloadUrl, uploadUrl, eventSourceUrl, exclusively for
session responses. Simple text (String) suffices for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
