woj-tek commented on PR #2342: URL: https://github.com/apache/james-project/pull/2342#issuecomment-2271329710
Thank you @Arsnael for explanation. > I believe the current mpt test has value as it allowed catching issues regular unit tests did not. I would be extremely caitious if alterations are needed. I totally agree that MPT tests are very valuable (more akin "integration tests"). Though trying to understand the issue and what's going on so more querying for information and not even suggesting changing those :) > Btw we pass this very test with opensearch meaning this is doable on a lucene based setup... This should be more than doable, especially considering that it's working with current implementation - correct? Though as @Arsnael mention the issue seems to be different. What bugs me is why actual unit-tests pass. Looking at `org.apache.james.mailbox.store.search.AbstractMessageSearchIndexTest#searchShouldReturnSeenMessagesWhenFlagsGotUpdated` it should be somewhat similar case. Ideally I'd like to create a unit-test in `apache-james-mailbox-lucene` that shows the issue and take it from there :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
