quantranhong1999 commented on code in PR #2399:
URL: https://github.com/apache/james-project/pull/2399#discussion_r1744902969
##########
server/protocols/webadmin/webadmin-core/src/main/java/org/apache/james/webadmin/routes/HealthCheckRoutes.java:
##########
@@ -56,15 +63,17 @@ public class HealthCheckRoutes implements PublicRoutes {
public static final String HEALTHCHECK = "/healthcheck";
public static final String CHECKS = "/checks";
-
+
private static final String PARAM_COMPONENT_NAME = "componentName";
+ private static final String QUERY_PARAM_COMPONENT_NAMES = "checks";
private final JsonTransformer jsonTransformer;
- private final Set<HealthCheck> healthChecks;
+ private final Map<ComponentName, HealthCheck> healthCheckMap;
Review Comment:
> iterating through the set is needed and the cost is perf.
Not that much IMO:
- the set size is small
- healthcheck does not need to be super performant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
