chibenwa commented on code in PR #2409:
URL: https://github.com/apache/james-project/pull/2409#discussion_r1758259186
##########
mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsSMIMESigned.java:
##########
@@ -45,8 +45,7 @@ public Collection<MailAddress> match(Mail mail) throws
MessagingException {
if (message == null) {
return null;
}
-
-
+
Review Comment:
THis one is a simple mailet only checking content type and its logic is not
well exercised by the integration tests. (Ultimate proof: this PR did not
affect the logic of the integration tests...)
I do believe unit test makes full sense here and are quick and easy to write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
