superbAura commented on PR #2410: URL: https://github.com/apache/james-project/pull/2410#issuecomment-2378327136
> Alright the code seems ok now, I will merge and squash all of this on github's end. > > Just maybe for next time, on your PR instead of doing numerous git merge with master that lead to absolute commit mess (40+ commits... it makes it hard to review), prefer maybe the git rebase instead? > > Like on your local branch : > > ``` > git fetch apache master > git rebase apache/master > > [fix conflicts if necessary] > > git push origin HEAD -f > ``` > > Would help keep a clean commit history, in sync with master branch, with making life of people reviewing your PR easier. > > Thank you for the contribution though, kindly appreciated :) It was a fun experience contributing to open source for the first time. I'll look for another task to work on ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
