chibenwa commented on code in PR #2446:
URL: https://github.com/apache/james-project/pull/2446#discussion_r1795363613
##########
server/protocols/protocols-smtp-dkim/src/main/java/org/apache/james/smtpserver/DKIMHook.java:
##########
@@ -165,7 +205,9 @@ public Config(boolean forceCRLF, boolean signatureRequired,
Optional<Domain> onl
DKIMCheckNeeded dkimCheckNeeded() {
return onlyForSenderDomain
- .map(DKIMCheckNeeded::onlyForSenderDomain)
+ .map(domain -> DKIMCheckNeeded.or(
+ DKIMCheckNeeded.onlyForSenderDomain(domain),
+ DKIMCheckNeeded.onlyForHeaderFromDomain(domain)))
Review Comment:
What would be perfect would be to have it configurable.
`<validatedEntities>envelope,headers</validatedEntities>`
Defaults to both if unspecified, coma separated values.
This would enable greater flexibility when configuring this and would allow
for easy rollback to previous state.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
