chibenwa commented on code in PR #2485:
URL: https://github.com/apache/james-project/pull/2485#discussion_r1827771622
##########
server/blob/blob-api/src/main/java/org/apache/james/blob/api/BlobStore.java:
##########
@@ -43,45 +45,118 @@ interface BlobIdProvider {
Publisher<BlobId> save(BucketName bucketName, byte[] data, StoragePolicy
storagePolicy);
+ default Publisher<BlobId> save(Bucket bucket, byte[] data, StoragePolicy
storagePolicy) {
+ return save(bucket.bucketName(), data, storagePolicy);
+ }
Review Comment:
This makes it harder to use the class: we can not double the number of
methods every time we add some parameters.
I'd be happy we make it easy to get a Bucket from a BucketName and sollely
depend on bucket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
