quantranhong1999 commented on code in PR #2540:
URL: https://github.com/apache/james-project/pull/2540#discussion_r1866899272
##########
server/blob/blob-storage-strategy/src/main/scala/org/apache/james/server/blob/deduplication/DeDuplicationBlobStore.scala:
##########
@@ -67,40 +67,35 @@ class DeDuplicationBlobStore @Inject()(blobStoreDAO:
BlobStoreDAO,
private val baseEncoding =
Option(System.getProperty(HASH_BLOB_ID_ENCODING_TYPE_PROPERTY)).map(DeDuplicationBlobStore.baseEncodingFrom).getOrElse(HASH_BLOB_ID_ENCODING_DEFAULT)
override def save(bucketName: BucketName, data: Array[Byte], storagePolicy:
BlobStore.StoragePolicy): Publisher[BlobId] = {
- save(bucketName, data, withBlobId, storagePolicy)
+ save(bucketName, data, withBlobIdFromArray, storagePolicy)
}
override def save(bucketName: BucketName, data: InputStream, storagePolicy:
BlobStore.StoragePolicy): Publisher[BlobId] = {
save(bucketName, data, withBlobId, storagePolicy)
}
override def save(bucketName: BucketName, data: ByteSource, storagePolicy:
BlobStore.StoragePolicy): Publisher[BlobId] = {
- save(bucketName, data, withBlobId, storagePolicy)
+ save(bucketName, data, withBlobIdFromByteSource, storagePolicy)
}
- override def save(bucketName: BucketName, data: Array[Byte], blobIdProvider:
BlobIdProvider, storagePolicy: BlobStore.StoragePolicy): Publisher[BlobId] = {
+ override def save(bucketName: BucketName, data: Array[Byte], blobIdProvider:
BlobIdProvider[Array[Byte]], storagePolicy: BlobStore.StoragePolicy):
Publisher[BlobId] = {
Preconditions.checkNotNull(bucketName)
Preconditions.checkNotNull(data)
- save(bucketName, new ByteArrayInputStream(data), blobIdProvider,
storagePolicy)
+ save(bucketName, data, blobIdProvider, storagePolicy)
Review Comment:
Likely not finished here
```suggestion
SMono(blobIdProvider.apply(data))
.map(_.getT1)
.flatMap(blobId => SMono(blobStoreDAO.save(bucketName, blobId, data))
.`then`(SMono.just(blobId)))
```
Should solve the `java.lang.StackOverflowError`. We should double check
other places too cc @vttranlina.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
