chibenwa commented on code in PR #2541: URL: https://github.com/apache/james-project/pull/2541#discussion_r1867097071
########## mpt/impl/imap-mailbox/core/src/main/java/org/apache/james/mpt/imapmailbox/suite/Delete.java: ########## @@ -0,0 +1,53 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.mpt.imapmailbox.suite; + +import java.util.Locale; + +import org.apache.james.mpt.api.ImapHostSystem; +import org.apache.james.mpt.imapmailbox.ImapTestConstants; +import org.apache.james.mpt.imapmailbox.suite.base.BasicImapCommands; +import org.apache.james.mpt.script.SimpleScriptedTestProtocol; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +public abstract class Delete implements ImapTestConstants { Review Comment: Do not add a new test. Put your new MPT script within `AuthenticatedState` where delete command is already tested. ########## protocols/imap/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java: ########## @@ -55,6 +56,11 @@ public DeleteProcessor(MailboxManager mailboxManager, StatusResponseFactory fact protected Mono<Void> processRequestReactive(DeleteRequest request, ImapSession session, Responder responder) { MailboxManager mailboxManager = getMailboxManager(); MailboxPath mailboxPath = pathConverterFactory.forSession(session).buildFullPath(request.getMailboxName()); + if (DefaultMailboxes.INBOX.equals(mailboxPath.getName())) { + LOGGER.debug("Deleting INBOX mailbox is not allowed"); Review Comment: INFO ########## protocols/imap/src/main/java/org/apache/james/imap/processor/DeleteProcessor.java: ########## @@ -55,6 +56,11 @@ public DeleteProcessor(MailboxManager mailboxManager, StatusResponseFactory fact protected Mono<Void> processRequestReactive(DeleteRequest request, ImapSession session, Responder responder) { MailboxManager mailboxManager = getMailboxManager(); MailboxPath mailboxPath = pathConverterFactory.forSession(session).buildFullPath(request.getMailboxName()); + if (DefaultMailboxes.INBOX.equals(mailboxPath.getName())) { Review Comment: According to RFC-3501, the INBOX name is case incentive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
