j-hellenberg opened a new pull request, #2588: URL: https://github.com/apache/james-project/pull/2588
[James-4099](https://issues.apache.org/jira/projects/JAMES/issues/JAMES-4099) Add a configuration switch for adjusting the default mailbox folder delimiter. Currently allowed (because unit-tested) values are: `dot` (will use '.' as delimiter), `slash` (will use '/' as delimiter), `pipe` ('|'), `comma` (','), `colon` (':'), `semicolon` (';'). Currently explicitly left-out values are: '#' (clashes with namespace prefix character), '\\' (anticipated some problems with the prefixedRegex matching and because it is the escaping character, it can generally be a bit more annoying to deal with in strings). This feature is opt in - the default configuration will still retain the current default delimiter (dot). **Notes to reviewer:** - Unfortunately, git becomes pretty confused when indentation of a large code chunk is changed. For this reasons, it might make sense to look at some commits individually - I specifically separated refactoring and correctly intending the `MailPathTests` and `PrefixedRegexTests` into their own commits to improve diff readability. - There may be more places in the code where '.' is used as a hard-coded constant. Is this an issue? Obviously, the dot used in `Domain.java` or `MailAddress.java` is independent of the mailbox folder delimiter, but the `FileIntoAction`, for example, also has a hierarchy delimiter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
