Arsnael commented on code in PR #2693:
URL: https://github.com/apache/james-project/pull/2693#discussion_r2022173043
##########
backends-common/redis/src/main/java/org/apache/james/backends/redis/RedisHealthCheck.scala:
##########
@@ -62,46 +61,43 @@ class RedisHealthCheck @Inject()(redisConfiguration:
RedisConfiguration, redisCl
.onErrorResume(_ => SMono.just(Result.degraded(redisComponent, "Can not
connect to Redis.")))
@PreDestroy
- def close(): Unit = healthcheckPerform.close()
+ def close(): Unit =
+ Mono.fromCompletionStage(rawRedisClient.shutdownAsync())
+ .subscribeOn(Schedulers.boundedElastic())
+ .subscribe()
}
sealed trait RedisHealthcheckPerform {
def check(): SMono[Result]
-
- def close(): Unit
}
-class RedisStandaloneHealthCheckPerform(val redisConfiguration:
StandaloneRedisConfiguration,
- val redisClientFactory:
RedisClientFactory,
- val healthcheckTimeout: Duration)
extends RedisHealthcheckPerform {
+class RedisRegularHealthCheckPerform(val redisClient: RedisClient,
redisConfiguration: RedisConfiguration) extends RedisHealthcheckPerform {
Review Comment:
Those classes literally disappear in the commit right after to just have
only 1 healthcheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
