quantranhong1999 commented on code in PR #2801:
URL: https://github.com/apache/james-project/pull/2801#discussion_r2336204752
##########
server/data/data-jmap-cassandra/src/test/resources/json/eventComplex-v2.json:
##########
@@ -3,6 +3,24 @@
"eventId":0,
"aggregateId":"FilteringRule/bart",
"rules":[
+ {
Review Comment:
IMO, it is not a good practice to modify the backward version JSON(s) to
ensure backward compatibility for the deserializer remains (despite likely the
change in this PR is not a breaking change).
Maybe we can create a new JSON to test the start with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
