chibenwa commented on code in PR #2805: URL: https://github.com/apache/james-project/pull/2805#discussion_r2346905411
########## server/apps/postgres-app/src/main/java/org/apache/james/modules/data/PostgresDLPConfigurationStoreModule.java: ########## @@ -31,6 +31,7 @@ import com.google.inject.TypeLiteral; import com.google.inject.multibindings.Multibinder; +//FIXME - I don't see what this has to do with postgres when it pulls stuff from data-cassandra ... Review Comment: I pulls from cassandra the event serialisation. We could argue that `org.apache.james.dlp.eventsourcing.cassandra.DLPConfigurationModules` could be relocated in `data-library` where both the PG and the Cassandra implen can depend on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
