chibenwa commented on code in PR #2810:
URL: https://github.com/apache/james-project/pull/2810#discussion_r2350013468


##########
server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/NoAuthCmdHandlerLoader.java:
##########
@@ -56,7 +56,6 @@ public class NoAuthCmdHandlerLoader implements 
HandlersPackage {
             RsetCmdHandler.class.getName(),
             VrfyCmdHandler.class.getName(),
             MailSizeEsmtpExtension.class.getName(),
-            UsersRepositoryAuthHook.class.getName(),

Review Comment:
   No to the contrary it is VERY related.
   
   The idea is that because there is no `AuthCmdHandler` then 
`UsersRepositoryAuthHook` is unused.
   
   Also the idea is to cleanup `NoAuthCmdHandler` so that it can be freely 
reused with other AuthHooks and thus easily and fully customize the 
authentication backend as is done here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to