Arsnael commented on code in PR #2811:
URL: https://github.com/apache/james-project/pull/2811#discussion_r2350500895
##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/filtering/Rule.java:
##########
@@ -129,33 +129,58 @@ public String toString() {
public static class Condition {
- public enum Field {
- FROM("from"),
- TO("to"),
- CC("cc"),
- SUBJECT("subject"),
- RECIPIENT("recipient");
+ public interface Field {
+ Field FROM = new FixedField("from");
+ Field TO = new FixedField("to");
+ Field CC = new FixedField("cc");
+ Field SUBJECT = new FixedField("subject");
+ Field RECIPIENT = new FixedField("recipient");
Review Comment:
Duplicated with declarations in FixedField? Those ain't necessary in the
interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
