chibenwa commented on code in PR #2813:
URL: https://github.com/apache/james-project/pull/2813#discussion_r2354784122
##########
server/apps/cassandra-app/pom.xml:
##########
@@ -326,6 +326,13 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <skipTests>true</skipTests>
+ </configuration>
+ </plugin>
Review Comment:
I'm reluctant having tests and not running them.
I'd propose to either:
- 1. assume and fully remove the tests
- 2. OR just keep run them until 3.9.0 and effective removal
- 3. OR be smart and run them only for master built (we can have 2 CI
profile, one for master, one PRs and other branches and disable those tests
when not on main)
If asked I'd go for 2 or 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
