jeantil commented on PR #2814: URL: https://github.com/apache/james-project/pull/2814#issuecomment-3305301730
I have been thinking about this again. I would much prefer we merge the changes incrementally and accumulate datapoints before merging the next set of changes. This is especially true for the forkCount changes : the result they introduce will be highly dependant on the hardware they run on, in some situations they may even have adverse effect. Merging more parallelization at the same time as merging changes that are guaranteed to have a positive impact may end up hiding a negative impact. if I were doing this at work, I would keep the fork count changes in a branch for some time ( a couple of weeks ?) and setup an automatic rebase for every merge on master to accumulate datapoints on both setups and make sure the increased parallelization actually has a positive effect. Changes that are guaranteed to have a positive impact are test removals for instance. executing less stuff can never take longer :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
