quantranhong1999 commented on PR #2845:
URL: https://github.com/apache/james-project/pull/2845#issuecomment-3489640716
> have you tried running the maven build locally ?
Was it failing too ?
It passed in my local.
```
➜
~/IdeaProjects/tmail-backend/james-project/server/protocols/jmap-rfc-8621-integration-tests/memory-jmap-rfc-8621-integration-tests
git:(filter-action-set-should-support-shared-mailbox) ✗ mvn -B -e -fae clean
test ${MVN_SHOW_TIMESTAMPS} -P ci-test ${MVN_LOCAL_REPO_OPT}
-Dassembly.skipAssembly=true
...
[WARNING] Tests run: 130, Failures: 0, Errors: 0, Skipped: 2, Time elapsed:
60.33 s -- in org.apache.james.jmap.rfc8621.memory.MemoryEmailQueryMethodTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1345, Failures: 0, Errors: 0, Skipped: 5
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 08:28 min
[INFO] Finished at: 2025-10-30T13:49:12+07:00
[INFO]
------------------------------------------------------------------------
[INFO] 10 goals, 10 executed
```
> If I read that correctly, I think the commit only makes [non-ABI
changes](https://docs.gradle.com/develocity/maven-build-cache/#non_abi_change)
one of which is to a scalal trait
It seems indeed the case. Do you think we should change the test name, so it
turns into a [ABI
change](https://docs.gradle.com/develocity/maven-build-cache/#abi_change) and
force `both the api and impl project are recompiled and retested`?
> Sounds like a flaky test more than a build cache issue then
The test failed on an outdated and non-existent assertion, so it was a build
cache issue IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
