vttranlina commented on code in PR #2878:
URL: https://github.com/apache/james-project/pull/2878#discussion_r2597639166
##########
mpt/impl/smtp/core/pom.xml:
##########
@@ -69,6 +69,11 @@
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
</dependency>
+ <dependency>
+ <groupId>junit</groupId>
Review Comment:
I tried to update FakeSmtp to JUnit 5, but the change is not straightforward.
FakeSmtp relies on DockerContainer, which still uses JUnit 4, and that class
is used widely across the codebase.
Hence re-add junit4 here is simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
