jeantil commented on PR #2894: URL: https://github.com/apache/james-project/pull/2894#issuecomment-3754245233
I think there is a misunderstanding : - I don't think this requires an ADR but I do agree it's a worthwhile change - I didn't completely agree with Benoit's [proposed implementation direction](https://github.com/apache/james-project/pull/2904#issuecomment-3737578076) and reminded him of an alternative which already exists in the code base and encodes the virtual path/virtual folder in the blob id instead of changing the bucketname Note that my only concern with Benoit's change was that it resulted in a breaking change in the [BucketNameResolver](https://github.com/apache/james-project/pull/2904/files#diff-75a7e5fdbf951c0dd72f96c82d77adf4414e6420ff93ff98d1bf12c1ad7636b0) api contract. The change didn't break code in james but since this is a public contract which has been published in official releases we must follow the process for introducing breaking changes. I don't even dispute the point that it is unlikely to actually have been used, but there is no way to know for sure. Benoit closed the MR at this point and you are doing the same saying you will move the development to your closed source extension, which is your right but also a bit sad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
