jeantil commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2694708448
##########
mailbox/plugin/deleted-messages-vault-cassandra/src/main/java/org/apache/james/vault/metadata/StorageInformationDAO.java:
##########
@@ -47,15 +47,15 @@ public class StorageInformationDAO {
private final PreparedStatement addStatement;
private final PreparedStatement removeStatement;
private final PreparedStatement readStatement;
- private final BlobId.Factory blobIdFactory;
+ private final BlobIdTimeGenerator blobIdTimeGenerator;
@Inject
- StorageInformationDAO(CqlSession session, BlobId.Factory blobIdFactory) {
+ StorageInformationDAO(CqlSession session, BlobIdTimeGenerator
blobIdTimeGenerator) {
this.cassandraAsyncExecutor = new CassandraAsyncExecutor(session);
this.addStatement = prepareAdd(session);
this.removeStatement = prepareRemove(session);
this.readStatement = prepareRead(session);
- this.blobIdFactory = blobIdFactory;
+ this.blobIdTimeGenerator = blobIdTimeGenerator;
Review Comment:
Why not have a custom BlobId.Factory implementation here to avoid changing
the API and affecting the cassandra variant for a S3 only problem ?
check
https://github.com/apache/james-project/blob/master/server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepositoryFactory.scala#L29
for an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
