chibenwa commented on code in PR #2919:
URL: https://github.com/apache/james-project/pull/2919#discussion_r2728175645
##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMessageManager.java:
##########
@@ -76,7 +76,6 @@ public
PostgresMessageManager(PostgresMailboxSessionMapperFactory mapperFactory,
this.mailbox = mailbox;
}
-
Review Comment:
We are missing the critical changes of
`mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMessageManager.java`
where we actually chose which messageStorer we want: I suspect a rebase issue.
##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMailboxSessionMapperFactory.java:
##########
@@ -146,14 +150,17 @@ public PostgresAttachmentMapper
getAttachmentMapper(MailboxSession session) {
return createAttachmentMapper(session);
}
+ public boolean isAttachmentStorageEnabled() {
Review Comment:
I cannot find where this is actually used
##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMailboxSessionMapperFactory.java:
##########
@@ -95,24 +99,24 @@ public MailboxMapper createMailboxMapper(MailboxSession
session) {
@Override
public MessageMapper createMessageMapper(MailboxSession session) {
return new
PostgresMessageMapper(executorFactory.create(session.getUser().getDomainPart()),
- getModSeqProvider(session),
- getUidProvider(session),
- blobStore,
- clock,
- blobIdFactory,
- attachmentIdAssignationStrategy);
+ getModSeqProvider(session),
+ getUidProvider(session),
+ blobStore,
+ clock,
+ blobIdFactory,
+ attachmentIdAssignationStrategy);
}
@Override
public MessageIdMapper createMessageIdMapper(MailboxSession session) {
return new PostgresMessageIdMapper(new
PostgresMailboxDAO(executorFactory.create(session.getUser().getDomainPart())),
- new
PostgresMessageDAO(executorFactory.create(session.getUser().getDomainPart()),
blobIdFactory),
- new
PostgresMailboxMessageDAO(executorFactory.create(session.getUser().getDomainPart())),
- getModSeqProvider(session),
- getAttachmentMapper(session),
- blobStore,
- blobIdFactory,
- clock);
+ new
PostgresMessageDAO(executorFactory.create(session.getUser().getDomainPart()),
blobIdFactory),
+ new
PostgresMailboxMessageDAO(executorFactory.create(session.getUser().getDomainPart())),
+ getModSeqProvider(session),
+ getAttachmentMapper(session),
+ blobStore,
+ blobIdFactory,
+ clock);
Review Comment:
The diff is full of reindents that makes it harder to read and harder to
find what really changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
