chibenwa commented on PR #2926:
URL: https://github.com/apache/james-project/pull/2926#issuecomment-3810213998
Not adding a MailboxManager method that's for sure.
> should we refactor the API interface in another PR?
I'd prefer the refactorings to be a preliminary work actually
Also we said `collapseThread should be a property of SearchQuery` POJO, and
`Let's use a collapse for messageId dedup`
I think the changeset would be easier with those.
Suggestion:
- [ ] Start 1. by using collapse for email Id and drop scroll for JMAP
- [ ] Second 2. Modify the search API with SearchOptions and push the
offsets onto the search engine
- [ ] Third 3. add collapseTHread options onto Search query, implement
openSearch, with search enging low level tests
- [ ] Fourth 4. Expose this fully onto the JMAP layer
4 small incremental steps that each individually adds value.
Opinion @quantranhong1999 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
