felixauringer commented on code in PR #2916:
URL: https://github.com/apache/james-project/pull/2916#discussion_r2743517894
##########
protocols/managesieve/src/main/java/org/apache/james/managesieve/core/CoreProcessor.java:
##########
@@ -64,7 +64,7 @@ interface CommandWrapper {
String execute() throws ManageSieveException,
SieveRepositoryException, IOException;
}
- public static final String IMPLEMENTATION_DESCRIPTION = "Apache
ManageSieve v1.0";
+ public static final String IMPLEMENTATION_DESCRIPTION = "Apache James
ManageSieve 3.9.0";
Review Comment:
I definitely see why you put the version here but maybe it would be nice to
have it as a constant somewhere? Changing it here (and probably in other
places) and in many tests for every version seems cumbersome to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
