quantranhong1999 commented on code in PR #2928: URL: https://github.com/apache/james-project/pull/2928#discussion_r2753111632
########## mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchOptions.java: ########## @@ -0,0 +1,41 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.mailbox.model; + +import org.apache.james.util.streams.Limit; +import org.apache.james.util.streams.Offset; + +import com.google.common.base.Preconditions; + +public record SearchOptions(Offset offset, Limit limit) { + public static SearchOptions limit(Limit limit) { + return SearchOptions.of(Offset.none(), limit); + } + + public static SearchOptions of(Offset offset, Limit limit) { + return new SearchOptions(offset, limit); + } + + public SearchOptions { + Preconditions.checkNotNull(offset, "'offset' is mandatory"); + Preconditions.checkNotNull(limit, "'limit' is mandatory"); + Preconditions.checkArgument(!limit.isUnlimited(), "'limit' cannot be unlimited"); Review Comment: > JMAP layer would construct and pass Bounded, the IMAP layer would pass directly SearchOptions. I do not think this code change is needed as of now, please do not need to commit this now, but it is meant as an example of how we can tweak the object modal around such limitations. Thanks. Interesting example! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
