omerfarukicen commented on PR #2940: URL: https://github.com/apache/james-project/pull/2940#issuecomment-3897488931
The test `parseShouldSuccessWhenAttachment` fails because the `size` value changed from `797` to `807`. This is expected: the old code used `SizeUtils.sizeOf(entity)` which computes size via `SingleBody.size()` (decoded size), while the new code uses the actual byte count from `DefaultMessageWriter.writeBody()` (the real serialized size). The 10-byte difference comes from this discrepancy. Since `807` reflects the true size of the written blob content (consistent with Content-Length and the actual download stream), I believe the test expectation should be updated to `807`. Shall I update the test to expect `807` instead of `797`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
