tejasae-afk opened a new pull request, #2981: URL: https://github.com/apache/james-project/pull/2981
Was reading through mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSessionBuilder.java and the resource opened there can leak if addProtocolLines exits on an error path. this patch moves the allocation into try-with-resources so cleanup happens on every exit path. Not sure if this is intentional, so feel free to ignore. Happy to revise the approach or close this if it doesn’t fit — you know the codebase far better than I do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
