Arsnael commented on code in PR #2991:
URL: https://github.com/apache/james-project/pull/2991#discussion_r3038691142
##########
event-bus/api/src/main/java/org/apache/james/events/EventSerializer.java:
##########
@@ -22,29 +22,30 @@
import java.nio.charset.StandardCharsets;
import java.util.Collection;
import java.util.List;
+import java.util.Optional;
public interface EventSerializer {
- String toJson(Event event);
+ Optional<String> toJson(Event event);
Review Comment:
I will try now. Sorry should have precised it. I wanted though to have a
build in parallel to see if tests are breaking somewhere that I missed or not
as well, that's it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
