felixauringer opened a new pull request, #3044: URL: https://github.com/apache/james-project/pull/3044
Benoit asked in https://issues.apache.org/jira/browse/JAMES-4205 that independent of the authentication mechanism, James should perform provisioning. To fulfill that requirement, I introduced (or rather repurposed) the method `authSuccess` to perform all operations that are necessary after a successful operation. While I was at it, I also introduced `authFailure` which is called quite often and therefore should reduce the complexity quite a bit. This also changes the semantics a little in some places, mainly because every failure is now consistently logged with AuditTrail and effects the failure count. I am still running tests but I would also appreciate if somebody more familiar with the code base could validate that I did not accidentally change the semantics in some place other than log messages. Additionally, I am not sure where `session.stopDetectingCommandInjection();` is supposed to be used but I could not find any logic to how it was used before and changed it so that it is consistently called after every processed request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
