felixauringer commented on PR #3049: URL: https://github.com/apache/james-project/pull/3049#issuecomment-4545173842
> It was backported to previous release branches I presume, not yet released Hm, then it should maybe be backported. My webmail client (Roundcube) couldn't use Managesieve with the master branch. Luckily, it's a really small change. > This was not a security issue but more the fact we do not re-advertize capability after STARTTLS Makes sense, after STARTTLS, re-advertizing is indeed necessary. > Then fair sorry I may have misunderstood the ABNF or read the RFC too quickly. No worries, I also overlooked it when first reading it and searched for the error in the Roundcube codebase for a while because I was convinced that your patch fulfilled the RFC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
