chibenwa commented on code in PR #3059: URL: https://github.com/apache/james-project/pull/3059#discussion_r3348923700
########## protocols/api/src/main/java/org/apache/james/protocols/api/sasl/SaslMechanism.java: ########## @@ -0,0 +1,45 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.protocols.api.sasl; + +/** + * Protocol-neutral SASL mechanism. + */ +public interface SaslMechanism { + /** + * Returns the SASL mechanism name advertised to clients. + */ + String name(); + + /** + * Whether this mechanism can be used by the supplied protocol. + */ + boolean supports(SaslProtocol protocol); + + /** + * Whether this mechanism is currently usable for the supplied session context. + */ + boolean isAvailable(SaslSessionContext context); Review Comment: Mmm I see where this come from: disable auth on unencrypted channels. But how is this specific to a given SASL mechanism ? In this case we just do not want to allow ANY kind of auth no? Also if that's about: disable XYZ auth then really the new way of doing it is so change the loaded list of SASLMechanisms. (we 'd be able to infer the sasl machanism to be loaded for retro compatibility). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
