chibenwa commented on code in PR #3059:
URL: https://github.com/apache/james-project/pull/3059#discussion_r3363864014
##########
examples/custom-imap/src/main/resources/imapserver.xml:
##########
@@ -55,6 +63,14 @@ under the License.
<customProperties>pong.response=bad</customProperties>
<customProperties>prop.b=baad</customProperties>
<gracefulShutdown>false</gracefulShutdown>
+ <auth>
+
<saslMechanisms>PlainSaslMechanism,OauthBearerSaslMechanism,XOauth2SaslMechanism,org.apache.james.examples.imap.sasl.ExampleTokenSaslMechanism</saslMechanisms>
+
<saslAuthenticationServiceFactoryProviderExtensions>org.apache.james.examples.imap.sasl.ExampleTokenSaslAuthenticationServiceFactoryProvider</saslAuthenticationServiceFactoryProviderExtensions>
Review Comment:
Leverage extensions.properties extra modules for this.
And avoid to set up yet-an-other axis of modularity.
That's Guice job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
