quantranhong1999 commented on code in PR #3059: URL: https://github.com/apache/james-project/pull/3059#discussion_r3425555405
########## protocols/sasl/src/main/java/org/apache/james/protocols/sasl/JamesSaslAuthenticator.java: ########## @@ -0,0 +1,93 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.protocols.sasl; + +import java.util.Optional; + +import jakarta.inject.Inject; + +import org.apache.james.core.Username; +import org.apache.james.mailbox.Authenticator; +import org.apache.james.mailbox.Authorizator; +import org.apache.james.mailbox.exception.MailboxException; +import org.apache.james.protocols.api.sasl.SaslAuthenticationResult; +import org.apache.james.protocols.api.sasl.SaslAuthenticator; +import org.apache.james.protocols.api.sasl.SaslFailure; +import org.apache.james.protocols.api.sasl.SaslIdentity; + +public class JamesSaslAuthenticator implements SaslAuthenticator { + private final Authenticator authenticator; + private final Authorizator authorizator; + + @Inject + public JamesSaslAuthenticator(Authenticator authenticator, Authorizator authorizator) { Review Comment: IMO, we should avoid injecting `SessionProvider` directly into SASL mechanisms because `SessionProvider` returns `MailboxSession`, which is an IMAP/mailbox-specific session object. For example, if SMTP later reuses OAUTHBEARER, the mechanism should not create a `MailboxSession`. SMTP only needs the authenticated/authorized identity to update its own SMTP session state and relay/submission policy. That is why I prefer keeping a small `SaslAuthenticator` wrapper: mechanisms perform credential validation and authorization, then return a protocol-neutral `SaslAuthenticationResult.Success(SaslIdentity)`. Each protocol remains responsible for initializing its own session model from that identity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
