prosgarz35 commented on code in PR #3198:
URL: https://github.com/apache/james-project/pull/3198#discussion_r4088074963
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapIdleStateHandler.java:
##########
@@ -42,7 +42,7 @@ public class ImapIdleStateHandler extends IdleStateHandler
implements NettyConst
private static final Logger LOGGER =
LoggerFactory.getLogger(ImapIdleStateHandler.class);
public ImapIdleStateHandler(int allIdleTimeSeconds) {
- this(0, 0, allIdleTimeSeconds);
+ this(allIdleTimeSeconds, 0, allIdleTimeSeconds);
Review Comment:
You are right regarding Windows file locking semantics: NTFS enforces
mandatory file locks on open file handles, which causes concurrency conflicts
during concurrent atomic replacements/deletions (concurrentSave... tests). On
Linux/POSIX systems, inode-based atomic rename(2) and advisory locks work
properly without concurrency issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
